Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getter/parser for PVGIS hourly-radiation #849

Closed
mikofski opened this issue Jan 8, 2020 · 3 comments · Fixed by #1186
Closed

getter/parser for PVGIS hourly-radiation #849

mikofski opened this issue Jan 8, 2020 · 3 comments · Fixed by #1186

Comments

@mikofski
Copy link
Member

mikofski commented Jan 8, 2020

Is your feature request related to a problem? Please describe.
Related to #845

Describe the solution you'd like
Similar to get_pvgis_tmy retrieve pvgis hourly radiation data from their api

Describe alternatives you've considered
Pvgis is becoming a popular resource more and more people are asking me for it, it is nice because it is a global collection of several different radiation databases including nsrdb and others, and different from cams, the data is complete, ie it has air temperature, wind speed as well as all 3 components of irradiance

Additional context
This would be part of the iotool sub-package. There's already a pvgis.py module with a getter for tmy be data

@AdamRJensen
Copy link
Member

@mikofski I'm developing a function for PVGIS hourly radiation and have a question to the person who developed the TMY function.

The get_pvgis_tmy function uses io.BytesIO(res.content) for the csv outputformat, whereas the epw format decodes the response: io.StringIO(res.content.decode('utf-8')). Is there a reason for not decoding the response for the csv outputformat (performance)? The reason I'm asking is that my code for _parse_pvgis_hourly_csv is much cleaner when the file-buffer has been decoded first.

@mikofski
Copy link
Member Author

Sorry, no good reason I can think of. I was probably just hacking at it until I could get it to work. Maybe I tried a string buffer first and had issues? I can't find your code for _parse_pvgis_hourly_csv, are you planning to open a pull request to close this issue? Would be great to clean up my mess with cleaner code if you have it. Thanks!

@AdamRJensen
Copy link
Member

@mikofski Thanks for the update, it could have been some smart trick I wasn't aware of. I'm opening a pull request within the next few days to add functions for PVGIS hourly radiation and then in a second pull I can clean up the TMY so they follow similar formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants