Tests are failing with the forked vt100 crate

[cyqsimon]

First of all, due to the crate rename, all references to vt100 need to be replaced with mprocs_vt100.

But even after I fixed that by adding use mprocs_vt100 as vt100; where necessary, quite a few tests are still failing. See log.

test-fail.log

[pvolok]

I didn't change code related to those failing tests. The vt100 seems to be unmaintained, so at some point these tests might need to be fixed in this repo. But for now I think it's safe to ignore them.

[cyqsimon]

Okay good to hear. I was only concerned because I had packaged mprocs here, and I was having test failures (and therefore build failures). If you think it's okay I'll just go ahead and disable the tests.

Just out of curiosity, do you think it's likely that those faulty tests will be fixed/removed in the future, either by this fork of vt100 or upstream?

[pvolok]

After quickly checking a couple of failing tests, it is not clear which behavior is correct - expected or actual.

[cyqsimon]

Alright. I'll disable the tests for mprocs-vt100 and leave this issue open for now. Thanks for the assistance!

[GaetanLepage]

Hello,
I tried to compile mprocs 0.6.3 and faced a compilation failure related to vt100.
Note: this is done within the nix ecosystem, but I think that the actual error is due to mprocs itself.

Here is the log I get: https://gist.github.com/GaetanLepage/431d34fe2eafe8480e0eca91101e96a2

Am I doing something wrong ?

Thank you very much for your help !

PS: Why does the mprocs crate indicates version 0.6.2 instead of 0.6.3 ?

[ptrcnull]

currently it looks like only one test fails:

---- bs stdout ----
thread 'bs' panicked at 'assertion failed: `(left == right)`
  left: `"faa\n baruux"`,
 right: `"faa\nbarx"`', vendor/vt100/tests/helpers/fixtures.rs:256:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[jayvdb]

I ran cargo test in vendor/vt100 and all tests passed (or where ignored). Problem fixed?

[pvolok]

Yes, tests were fixed. Thank you.