Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create versioncheck entry for StarCraft 1.17.0 #217

Closed
RElesgoe opened this issue Jul 25, 2016 · 14 comments
Closed

Create versioncheck entry for StarCraft 1.17.0 #217

RElesgoe opened this issue Jul 25, 2016 · 14 comments

Comments

@RElesgoe
Copy link
Member

RElesgoe commented Jul 25, 2016

# StarCraft: Brood War 1.17.0 - (Brood War mode)
"A=2521522835 B=3428392135 C=218673704 4 A=A^S B=B-C C=C+A A=A-B" \
 "ver-ix86-1.mpq" \
 IX86 \
 SEXP \
 "StarCraft.exe 07/11/16 15:59:46 1243112" \
 0x000000d5 \
 1.17.0.1 \
 0xcb82b07c \
 SEXP_1170
# StarCraft: Brood War 1.17.0 - (StarCraft mode)
"A=2521522835 B=3428392135 C=218673704 4 A=A^S B=B-C C=C+A A=A-B" \
 "ver-ix86-1.mpq" \
 IX86 \
 STAR \
 "StarCraft.exe 07/11/16 15:59:46 1243112" \
 0x000000d5 \
 1.17.0.1 \
 0xcb82b07c \
 STAR_1170
# StarCraft (Standalone) 1.17.0

Starting with 1.17.0, StarCraft and StarCraft: Brood War now requires CheckRevision's .dll to be digitally signed.
ver-IX86-#.zip

@Aloki
Copy link

Aloki commented Dec 28, 2016

# Starcraft (Standalone) 1.17.0
"A=2521522835 B=3428392135 C=218673704 4 A=A^S B=B-C C=C+A A=A-B" \
 "ver-IX86-1.mpq" \
 IX86 \
 STAR \
 "StarCraft.exe 07/11/16 15:59:51 1243112" \
 0x000000d5 \
 1.17.0.0 \
 0xa5e7b4cc \
 STAR_1170

@xpeh-owns
Copy link

What is actually the latest version of SC pvpgn works with?

@RElesgoe
Copy link
Member Author

@xpeh-owns without these versioncheck entries, 1.16.1, with the entries, 1.17.0

@xpeh-owns
Copy link

Which is the last version that uses old protocol?

@RElesgoe
Copy link
Member Author

@xpeh-owns 1.17.0

@xpeh-owns
Copy link

Would you update Supported Clients in readme.md?

@RElesgoe
Copy link
Member Author

@xpeh-owns The readme is updated, 1.17.0 won't work until these versioncheck entries are added to PvPGN.

@xpeh-owns
Copy link

So please add them :-P

@RElesgoe
Copy link
Member Author

There's a lot of other things to take care of, this is low priority.

@xpeh-owns
Copy link

It takes 2 minutes, lol.

@RElesgoe
Copy link
Member Author

You're free to make the changes and create a pull request for it.

@xpeh-owns
Copy link

This will take much more that 2 minutes as I never did this :-P

@xpeh-owns
Copy link

Is the problem just to add 2 entries to conf or something else?

@cen1
Copy link
Collaborator

cen1 commented Feb 12, 2018

Yes, that is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants