Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Add support for Attachments #13

Closed
hamin opened this issue Feb 27, 2016 · 6 comments
Closed

Add support for Attachments #13

hamin opened this issue Feb 27, 2016 · 6 comments

Comments

@hamin
Copy link
Contributor

hamin commented Feb 27, 2016

I actually need support for Attachments in the app I'm working on. @muratayusuke's fork has this actually already done along with a bunch of other enhancements: muratayusuke@0baf74d

Would love to see a PR @muratayusuke to pull his fork's changes into upstream. If not I can always make a PR just for the Attachment support but really it would just be duplicating @muratayusuke's efforts. Thoughts?

@pvzig
Copy link
Owner

pvzig commented Feb 27, 2016

I've actually added support for attachments and merged it to the master branch (see here: 89f5e37) but it's not in a release yet if you're pulling via CocoaPods or SPM. Was hoping to get the RTM team profile events done and do a release but I got sidetracked this past week.

@hamin
Copy link
Contributor Author

hamin commented Feb 27, 2016

@pvzig ah cool on that note checkout @muratayusuke 's fork he also added Team Profile Icons. muratayusuke@8aa4ba2

Maybe it doesn't make sense to merge that fork yet? Not sure :) I will checkout master

@pvzig
Copy link
Owner

pvzig commented Feb 27, 2016

Just took a look, merged it down to master 👍

@pvzig pvzig closed this as completed Feb 27, 2016
@hamin
Copy link
Contributor Author

hamin commented Feb 27, 2016

👍

@muratayusuke
Copy link
Contributor

@pvzig Thank you for pulling my changes, and sorry for my lazy work... I'll follow this repo.

@pvzig
Copy link
Owner

pvzig commented Feb 28, 2016

@muratayusuke No worries, thanks for forking and contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants