Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts with failing tests #117

Closed
stefanor opened this issue Aug 11, 2023 · 4 comments
Closed

Fonts with failing tests #117

stefanor opened this issue Aug 11, 2023 · 4 comments

Comments

@stefanor
Copy link
Collaborator

Currently skipped in the test suite (as of #115):

  • crawford2
  • konto_slant
  • danc4
  • diet_cola
  • stronger_than_all

They need more investigation. Either bugs in the fonts or pyfiglet.

@peterbrittain
Copy link
Collaborator

Crawford2 should be addressed by #118.

@peterbrittain
Copy link
Collaborator

Stronger_than_all handled by whitespace fix.

Konto fonts look like they're hitting some bad unicode, so probably need some editing.

Pyramids looks like figlet is bugged, so I don't propose fixing.

That leaves danc4 and diet_cola.

@peterbrittain
Copy link
Collaborator

Turns out I had a little time to look at this...

  • danc4 was caused by premature optimization of an empty definition for " ", which broke the line splitting logic.
  • pyramid was a bug in figlet - it can't handle character 129. Converting the font to use 128 instead fixed it.
  • diet_cola was not defining rectangles for every character and so broke figlet and pyfiglet differently.
  • I also fixed the 5x8 font, which was using the wrong height in the header.

Propose we live with konto decoding issues and close this now.

@pwaller
Copy link
Owner

pwaller commented Sep 1, 2023

This seems reasonable to me. Thanks everyone for your hard work keeping on top of the things you noticed by filing and fixing issues. Closing this one for now, please file new issues for specific cases.

@pwaller pwaller closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants