Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chessli games ankify clarification on mistakes #15

Closed
nayyala opened this issue Feb 8, 2021 · 2 comments
Closed

chessli games ankify clarification on mistakes #15

nayyala opened this issue Feb 8, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@nayyala
Copy link

nayyala commented Feb 8, 2021

I've played ~180 games in lichess. I ran "chessli games ankify --since forever" and only got mistakes from 2 games

I played 7 within the last week and the csv comes up completely empty.

I'm not at that level where I only have 2/180 games with mistakes :p I think there might be something up with it, unless i'm not understanding what constitutes a mistake

@pwenker pwenker added the bug Something isn't working label Feb 8, 2021
@pwenker
Copy link
Owner

pwenker commented Feb 8, 2021

Thanks for reporting the issue!

  1. First problem are empty csv files. I will add a check that if there are not mistakes found in a game, then no csv file should be created instead of an empty one.
  2. Regarding the missing mistakes. There are two potential points:
    a) Chessli only finds mistakes for games that you (or your opponent) have analyzed on lichess. The reason is, that only then chessli can fetch an annotated pgn, which can then be parsed to find your mistakes. Admittedly, I didn't describe this in the docs, which I will do. I assume that this is the issue, can you please verify it?
    b) Also, at the moment there is a limit on the number of games you can fetch at once (set to 30, see the --max option). This is because lichess allows to fetch a maximum of 30 games per second and how the code is at the moment, you can try, but probably get an error if you try to set --max to a higher value. This might be solved in the future if needed, however, from a learning view point, I would recommend to only ankify recent games, as the workload will probably be large enough starting with the last 30 games.

PS: If it turns out you really only commited mistakes in 2 out of your 180 past games, do you need a manager? :D

@pwenker pwenker added documentation Improvements or additions to documentation and removed bug Something isn't working labels Feb 8, 2021
@pwenker
Copy link
Owner

pwenker commented Mar 5, 2021

This is fixed with v0.2.3.

Chessli now only creates csv files if they are non-empty and I added a note to the documentation here about the need to analyse games via lichess in order to find mistakes .

@pwenker pwenker closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants