Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is android.permission.CHANGE_WIFI_STATE really needed? #52

Closed
sregg opened this issue Apr 19, 2016 · 5 comments
Closed

Is android.permission.CHANGE_WIFI_STATE really needed? #52

sregg opened this issue Apr 19, 2016 · 5 comments

Comments

@sregg
Copy link

sregg commented Apr 19, 2016

and if so, for what purpose?

@pwittchen
Copy link
Owner

Hi. I needed it to implement one of the library functionalities. To be honest, right now I don't remember, which one. Probably it's related to observing WiFi access points. I'll investigate it later and give you more concrete answer.

@pwittchen
Copy link
Owner

Maybe it'll be good idea to extract observing WiFi access points functionality to a separate library, because issue #50 is similar to this one. It should reduce number of required permissions.

@sregg
Copy link
Author

sregg commented Apr 20, 2016

Yes that would be a good idea to sepparate the features
I managed to remove the unnecessary permissions using

<uses-permission
        android:name="android.permission.ACCESS_COARSE_LOCATION"
        tools:node="remove"/>

@pwittchen pwittchen mentioned this issue May 4, 2016
9 tasks
@pwittchen pwittchen modified the milestone: 0.4.0 May 30, 2016
@pwittchen
Copy link
Owner

pwittchen commented Jun 7, 2016

After merging PR #67 to the master branch, this permission can be removed from the Manifest of the library. In release v. 0.4.0, this permission will be no longer needed.

@pwittchen
Copy link
Owner

Permission removed by PR #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants