Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash uses eql? but rbtree uses == for searching #3

Open
cjheath opened this issue Oct 21, 2014 · 3 comments
Open

Hash uses eql? but rbtree uses == for searching #3

cjheath opened this issue Oct 21, 2014 · 3 comments

Comments

@cjheath
Copy link

cjheath commented Oct 21, 2014

rbtree does not drop-in as a replacement for Hash as easily as it ought to because it uses == for equality testing instead of eql?, for example here: https://github.com/pwnall/rbtree-pure/blob/master/lib/rbtree/tree.rb#L196

Granted you need to use <=>, but there's no good reason not to use eql?

@cjheath
Copy link
Author

cjheath commented Mar 29, 2016

Any update on this? 18 months have passed and the issue has not even been acknowledged.

@pwnall
Copy link
Owner

pwnall commented Apr 19, 2016

@cjheath Sorry for the lack of responsiveness. There's not much I can do without a failing test, and I don't have the time to look into that right now. Do you think you could help me by getting a failing test? Ideally, it would be in rbtree's testing suite as well.

Thank you!

@cjheath
Copy link
Author

cjheath commented Apr 19, 2016

Can do - but not today. I'll try to get to it this week. In fact I'll be happy to fix the problem and send a PR, if you are willing to accept that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants