Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_dependencies throws exception due to missing requirements.txt #1865

Closed
fidgetingbits opened this issue Aug 16, 2023 · 4 comments
Closed
Labels
Milestone

Comments

@fidgetingbits
Copy link
Contributor

Description

When an exception is triggered and you have set exception-verbose on the pwndbng exception handler will call a function called check_dependencies in pwndbg/exception.py, which will do the following:

    project_path = os.path.dirname(os.path.abspath(__file__))
    requirements_path = os.path.join(project_path, os.pardir, "requirements.txt")
    with open(requirements_path, "r") as f:

It seems like the requirements.txt file is only present in the docs/ folder atm, so this triggers its own exception. I confirmed that just symlinking requirements.txt to the real file fixes the issue.

Steps to reproduce

Run set exception-verbose on and cause pwndbg to trigger some python exception.

My setup

I am using the latest dev branch and am not running in the virtual environment

@disconnect3d
Copy link
Member

We moved dependencies versions to

pwndbg/pyproject.toml

Lines 261 to 273 in 3d6f864

[tool.poetry.dependencies]
python = "^3.8"
capstone = "5.0.0.post1"
psutil = "5.9.5"
pwntools = "4.10.0"
pycparser = "2.21"
pyelftools = "0.29"
pygments = "2.15.0"
ropgadget = "7.2"
tabulate = "0.9.0"
typing-extensions = "4.6.1"
unicorn = "2.0.1.post1"
requests = "2.31.0"

We need to fetch them differently here

@dmur1
Copy link
Contributor

dmur1 commented Aug 17, 2023

will take a look at this

@dmur1
Copy link
Contributor

dmur1 commented Aug 17, 2023

@disconnect3d #1880

@disconnect3d
Copy link
Member

Fixed in #1880. Let's skip check_deps for now... we can bring back this issue if someone reports yet another issue that is about outdated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants