Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff wrong on some files #529

Open
austinbutler opened this issue Mar 29, 2024 · 2 comments
Open

Diff wrong on some files #529

austinbutler opened this issue Mar 29, 2024 · 2 comments

Comments

@austinbutler
Copy link

austinbutler commented Mar 29, 2024

Issue Description

Type: bug report

Describe what happened (or what feature you want)

During PR review, on some files the syntax highlighting gets tripped up and it will consider the entire file new/changed.

Describe what you expected to happen

Only show the one line that changed as new instead of the whole file.

How to reproduce it (as minimally and precisely as possible)

I'm not sure on the repro, aside from:

  1. :Octo <url here>
  2. :Octo review start

Tell us your environment

Anything else we need to know?

The only config I've changed from default is set use_local_fs to true.

@igorlfs
Copy link

igorlfs commented Apr 5, 2024

I'm also having this issue, though I haven't found a consistent reproduction. With you, does that always happen when reviewing large files?

@austinbutler
Copy link
Author

austinbutler commented Apr 10, 2024

I had thought so, but I hadn't been paying close attention. However right now it's happening on a file with only 290 lines. I've updated the issue to be more accurate given that.

@austinbutler austinbutler changed the title Diff wrong on large files Diff wrong on some files Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants