Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to prevent new commands starting after an error #11

Open
pwr22 opened this issue Sep 19, 2018 · 2 comments
Open

Fails to prevent new commands starting after an error #11

pwr22 opened this issue Sep 19, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pwr22
Copy link
Owner

pwr22 commented Sep 19, 2018

This can occur if the commands from the initial batch are sent into the channel before the main goroutine starts. So basically if an error occurs in a command before all the initial commands are started then zoom will not stop all commands and exit early as expected

@pwr22 pwr22 added the bug Something isn't working label Sep 19, 2018
@pwr22 pwr22 added this to the v0.0.4 milestone Sep 19, 2018
@pwr22 pwr22 self-assigned this Sep 19, 2018
@pwr22 pwr22 modified the milestones: v0.0.4, v0.0.5 Sep 19, 2018
@pwr22
Copy link
Owner Author

pwr22 commented Sep 19, 2018

Could handle this by switching to starting the commands asyncronously, then passing the jobs back to the main routine so it knows what has started (and so what to kill - if it sees any start after an error then it can immediately kill)

Alternatively could work out if commands haven't started yet in the main routine and defer killing them somehow until they do

@pwr22
Copy link
Owner Author

pwr22 commented Sep 23, 2018

Should add a test to capture this before fixing

@pwr22 pwr22 closed this as completed Sep 23, 2018
@pwr22 pwr22 reopened this Sep 23, 2018
@pwr22 pwr22 modified the milestones: v0.0.5, v0.0.6 Sep 25, 2018
@pwr22 pwr22 removed this from the v0.0.6 milestone Feb 7, 2019
@pwr22 pwr22 added this to the v1.0.0 milestone Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant