Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Doesn't this always return True? #8

Closed
dvarrazzo opened this issue Sep 6, 2022 · 3 comments
Closed

Doesn't this always return True? #8

dvarrazzo opened this issue Sep 6, 2022 · 3 comments

Comments

@dvarrazzo
Copy link

https://github.com/vinylproject/vinyl/blob/4e0a7e1b4c30bb4a6887b4db59992961920f1ee7/vinyl/flags.py#L9

@pwtail
Copy link
Owner

pwtail commented Sep 6, 2022

No it doesn't. In the sync version hi_there is a regular function: https://github.com/vinylproject/vinyl/blob/4e0a7e1b4c30bb4a6887b4db59992961920f1ee7/vinyl_sync/vinyl/flags.py

@pwtail pwtail closed this as completed Sep 6, 2022
@dvarrazzo
Copy link
Author

How? It's kinda magic: doesn't it deserve a comment?

@pwtail
Copy link
Owner

pwtail commented Sep 6, 2022

the sync version is got from the async one by transpiling the code. Btw, I added a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants