Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #35

Merged
merged 26 commits into from Feb 23, 2023
Merged

Increase test coverage #35

merged 26 commits into from Feb 23, 2023

Conversation

Martysh12
Copy link
Contributor

Why

Increasing test coverage to at least 75% is a milestone this project has to reach before 1.0.0.

What

This pull request adds more tests, and tweaks coverage parameters in order to achieve this milestone.

Closes #10

@ItsDrike ItsDrike marked this pull request as ready for review February 16, 2023 21:31
@ItsDrike ItsDrike marked this pull request as draft February 16, 2023 21:31
@ItsDrike ItsDrike added t: enhancement Improvement to an existing feature p: 2 - normal Normal priority a: dependencies Related to package dependencies and management labels Feb 16, 2023
Martysh12 and others added 18 commits February 17, 2023 01:00
@Martysh12
Merge branch 'py-mine:main' into internal/increase-coverage
e547fd9
@Martysh12
Add tests for write_varint and write_varlong
d4e7af5
@Martysh12
Add test for write_bytearray
8359e72
@Martysh12
Add test for write_utf limit
fc1952d
@Martysh12
Add tests for read_varint and read_varlong
9923670
@Martysh12
Add test for read_bytearray
0cf1575
@Martysh12
Fix documentation in test_write_utf_limit
f8c749c
@Martysh12
Add test for read_utf limits
1835ac6
@Martysh12
Remove tests for write_utf and read_utf limits
7aaef25 
They cannot be reliably tested on Windows
@Martysh12
Revert "Remove tests for write_utf and read_utf limits"
72e264f 
This reverts commit 7aaef25.
@Martysh12
Skip write_utf&read_utf limit tests on Windows
e488cb6
@Martysh12
Add changelog fragment for py-mine#35
a63f38e
@Martysh12
Attempt to fix Windows check for some tests
f9a03ee
@Martysh12
Another attempt to fix the skips
543e74b
@Martysh12
Get rid of parametrize in some tests
df31472 
as an attempt to fix the Windows bug
@Martysh12
Add tests for two's complement functions\` limits
f6be8c1
@Martysh12
Workaround for a pytest.mark.parametrize bug
59c1b99
@Martysh12
Merge branch 'main' into internal/increase-coverage
d85ed23
@Martysh12
Copy link
Contributor Author

I've reached the goal! Coverage is 77.37%.

@Martysh12 Martysh12 marked this pull request as ready for review February 20, 2023 23:39
@ItsDrike ItsDrike merged commit 17b8682 into py-mine:main Feb 23, 2023
Martysh12 added a commit to Martysh12/mcproto that referenced this pull request Jun 10, 2023
@Martysh12
Add changelog fragment for py-mine#35
ce60d21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsDrike ItsDrike ItsDrike approved these changes

Assignees
No one assigned
Labels
a: dependencies Related to package dependencies and management p: 2 - normal Normal priority t: enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase coverage to at least 75%
2 participants
@Martysh12 @ItsDrike