Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login state packets #54

Merged
merged 11 commits into from Jun 8, 2023
Merged

Add login state packets #54

merged 11 commits into from Jun 8, 2023

Conversation

ItsDrike
Copy link
Member

@ItsDrike ItsDrike commented Mar 1, 2023

Add LOGIN state packets (wiki.vg docs).

Note: This required adding a ChatMessage type, which is currently versioned with the protocol versions. This therefore assumes #45 will end up only versioning the packets and types directories. If this will not be the case, this implementation will need to be reworked to meet a different versioning structure.

  • Make UUID type, as a wrapper around stdlib uuid.UUID, subclassing McType
  • Implement ChatMessage type
  • Add tests
    • for the login packets
    • for the new types

@ItsDrike ItsDrike added p: 2 - normal Normal priority t: feature New request or feature a: packets Related to packets (packet classes, or their reading/writing) a: API Related to exposed core API of the project labels Mar 1, 2023
@ItsDrike ItsDrike marked this pull request as ready for review June 8, 2023 13:03
@ItsDrike ItsDrike merged commit eef769b into main Jun 8, 2023
12 checks passed
@ItsDrike ItsDrike deleted the add-login-state branch June 8, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: API Related to exposed core API of the project a: packets Related to packets (packet classes, or their reading/writing) p: 2 - normal Normal priority t: feature New request or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant