Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minio 7.1.16 removed the second parameter of minio.api.Minio._get_region #135

Closed
ettoreleandrotognoli opened this issue Aug 30, 2023 · 3 comments · Fixed by #136
Closed

Minio 7.1.16 removed the second parameter of minio.api.Minio._get_region #135

ettoreleandrotognoli opened this issue Aug 30, 2023 · 3 comments · Fixed by #136

Comments

@ettoreleandrotognoli
Copy link
Contributor

I got this error

Minio._get_region() takes 2 positional arguments but 3 were given

from this line

django-minio-storage/minio_storage/storage.py

Line 116 in c01f000

region=client._get_region(bucket_name, None),

Looks that minio 7.1.16 removed the second parameter on this commit:

minio/minio-py@402f25e
ettoreleandrotognoli referenced this issue in minio/minio-py Aug 30, 2023
@balamurugana
Add generic AWS S3 domain support (#1289)
402f25e 
Signed-off-by: Bala.FA <bala@minio.io>
Merged
@ettoreleandrotognoli
Copy link
Contributor Author

I just rollback my application to minio==7.1.15, and it is working again

@thomasf
Copy link
Collaborator

thomasf commented Aug 30, 2023

We probably should require the AWS region to be configured in settings instead of doing all this reaching into minio-py internals but let's get this fix released asap.

@harshavardhana
Copy link

Unexported functions i.e not with _ - must not be used or relied upon generally speaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update minio to 7.1.16 ettoreleandrotognoli/django-minio-storage
3 participants
@thomasf @harshavardhana @ettoreleandrotognoli