Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Reduce PdfReader.read complexity #1151

Merged
merged 5 commits into from Jul 23, 2022
Merged

MAINT: Reduce PdfReader.read complexity #1151

merged 5 commits into from Jul 23, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma MartinThoma added the is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements label Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #1151 (a5bd6f7) into main (89c0ff2) will increase coverage by 0.02%.
The diff coverage is 81.31%.

@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
+ Coverage   92.12%   92.14%   +0.02%     
==========================================
  Files          24       24              
  Lines        4772     4785      +13     
  Branches      989      990       +1     
==========================================
+ Hits         4396     4409      +13     
  Misses        228      228              
  Partials      148      148              
Impacted Files Coverage Δ
PyPDF2/_reader.py 90.35% <81.31%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c0ff2...a5bd6f7. Read the comment docs.

@MartinThoma MartinThoma merged commit a6d27d7 into main Jul 23, 2022
@MartinThoma MartinThoma deleted the code-complexity branch July 23, 2022 08:00
MartinThoma added a commit that referenced this pull request Jul 24, 2022
New Features (ENH):
-  Add writer.add_annotation, page.annotations, and generic.AnnotationBuilder (#1120)

Bug Fixes (BUG):
-  Set /AS for /Btn form fields in writer (#1161)
-  Ignore if /Perms verify failed (#1157)

Robustness (ROB):
-  Cope with utf16 character for space calculation (#1155)
-  Cope with null params for FitH / FitV destination (#1152)
-  Handle outlines without valid destination (#1076)

Developer Experience (DEV):
-  Introduce _utils.logger_warning (#1148)

Maintenance (MAINT):
-  Break up parse_to_unicode (#1162)
-  Add diagnostic output to exception in read_from_stream (#1159)
-  Reduce PdfReader.read complexity (#1151)

Testing (TST):
-  Add workflow tests found by arc testing (#1154)
-  Decrypt file which is not encrypted (#1149)
-  Test CryptRC4 encryption class; test image extraction filters (#1147)

Full Changelog: 2.7.0...2.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-maintenance Anything that is just internal: Simplifying code, syntax changes, updating docs, speed improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant