Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Cope with utf16 character for space calculation #1155

Merged
merged 2 commits into from Jul 24, 2022

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented Jul 23, 2022

See #1143

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #1155 (6000b80) into main (c529884) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          24       24           
  Lines        4794     4798    +4     
  Branches      990      990           
=======================================
+ Hits         4423     4427    +4     
  Misses        230      230           
  Partials      141      141           
Impacted Files Coverage Δ
PyPDF2/_cmap.py 93.93% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c529884...6000b80. Read the comment docs.

@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jul 24, 2022
@MartinThoma MartinThoma changed the title ROB : cope with utf16 character for space calculation (#1143) ROB: Cope with utf16 character for space calculation (#1143) Jul 24, 2022
@MartinThoma MartinThoma changed the title ROB: Cope with utf16 character for space calculation (#1143) ROB: Cope with utf16 character for space calculation Jul 24, 2022
@MartinThoma MartinThoma merged commit 35bec40 into py-pdf:main Jul 24, 2022
@pubpub-zz pubpub-zz deleted the iss1143 branch July 24, 2022 07:32
MartinThoma added a commit that referenced this pull request Jul 24, 2022
New Features (ENH):
-  Add writer.add_annotation, page.annotations, and generic.AnnotationBuilder (#1120)

Bug Fixes (BUG):
-  Set /AS for /Btn form fields in writer (#1161)
-  Ignore if /Perms verify failed (#1157)

Robustness (ROB):
-  Cope with utf16 character for space calculation (#1155)
-  Cope with null params for FitH / FitV destination (#1152)
-  Handle outlines without valid destination (#1076)

Developer Experience (DEV):
-  Introduce _utils.logger_warning (#1148)

Maintenance (MAINT):
-  Break up parse_to_unicode (#1162)
-  Add diagnostic output to exception in read_from_stream (#1159)
-  Reduce PdfReader.read complexity (#1151)

Testing (TST):
-  Add workflow tests found by arc testing (#1154)
-  Decrypt file which is not encrypted (#1149)
-  Test CryptRC4 encryption class; test image extraction filters (#1147)

Full Changelog: 2.7.0...2.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soon PRs that are almost ready to be merged, issues that get solved pretty soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants