BUG: Ignore if '/Perms' verify failed #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
+ Coverage 92.11% 92.26% +0.15%
==========================================
Files 24 24
Lines 4791 4795 +4
Branches 990 990
==========================================
+ Hits 4413 4424 +11
Misses 230 230
+ Partials 148 141 -7
Continue to review full report at Codecov.
|
MartinThoma
approved these changes
Jul 24, 2022
MartinThoma
approved these changes
Jul 24, 2022
MartinThoma
changed the title
MartinThoma
added
the
is-bug
MartinThoma
added a commit
that referenced
this pull request
Jul 24, 2022
New Features (ENH): - Add writer.add_annotation, page.annotations, and generic.AnnotationBuilder (#1120) Bug Fixes (BUG): - Set /AS for /Btn form fields in writer (#1161) - Ignore if /Perms verify failed (#1157) Robustness (ROB): - Cope with utf16 character for space calculation (#1155) - Cope with null params for FitH / FitV destination (#1152) - Handle outlines without valid destination (#1076) Developer Experience (DEV): - Introduce _utils.logger_warning (#1148) Maintenance (MAINT): - Break up parse_to_unicode (#1162) - Add diagnostic output to exception in read_from_stream (#1159) - Reduce PdfReader.read complexity (#1151) Testing (TST): - Add workflow tests found by arc testing (#1154) - Decrypt file which is not encrypted (#1149) - Test CryptRC4 encryption class; test image extraction filters (#1147) Full Changelog: 2.7.0...2.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be save to ignore the /Perms entry:
Qpdf ignores it:
https://github.com/qpdf/qpdf/blob/main/libqpdf/QPDF_encryption.cc#L1064
pdfbox ignores it:
https://github.com/apache/pdfbox/blob/dc1a75027d5bebf95a3330f6298a533e78e0b99e/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/StandardSecurityHandler.java#L311
Closes #378