Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB : fix loading of file from #134 #1167

Merged
merged 2 commits into from Jul 25, 2022
Merged

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented Jul 24, 2022

a) cmap : strip lines when processing cmap from fonts
b) look for %EOF up to beginning of file

test file in #134

a) cmap : strip lines when processing cmap from fonts
b) look for %EOF up to beginning of file
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #1167 (2211461) into main (0b27287) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          24       24           
  Lines        4811     4811           
  Branches      991      991           
=======================================
  Hits         4438     4438           
  Misses        231      231           
  Partials      142      142           
Impacted Files Coverage Δ
PyPDF2/_cmap.py 94.23% <ø> (ø)
PyPDF2/_reader.py 90.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b27287...2211461. Read the comment docs.

@MartinThoma MartinThoma merged commit 844f238 into py-pdf:main Jul 25, 2022
MartinThoma added a commit that referenced this pull request Jul 25, 2022
Bug Fixes (BUG):
-  u_hash in AlgV4.compute_key (#1170)

Robustness (ROB):
-  Fix loading of file from #134 (#1167)
-  Cope with empty DecodeParams (#1165)

Documentation (DOC):
-  Typo in warning message (#1166)

Maintenance (MAINT):
-  Package updates; solve mypy strict remarks (#1163)

Testing (TST):
-  Add test from #325 (#1169)

Full Changelog: 2.8.0...2.8.1
@pubpub-zz pubpub-zz deleted the iss134 branch August 8, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants