Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Digitally sign PDF document #653

Closed
zhangwuqiao opened this issue Feb 28, 2022 · 6 comments
Closed

ENH: Digitally sign PDF document #653

zhangwuqiao opened this issue Feb 28, 2022 · 6 comments
Labels
is-feature A feature request PdfWriter The PdfWriter component is affected

Comments

@zhangwuqiao
Copy link

Want to add the signature function of Digitally sign document.

@MartinThoma MartinThoma added the is-feature A feature request label Apr 6, 2022
@sgelis
Copy link

sgelis commented May 24, 2022

Any update/roadmap on this request? We would be delighted to help with this feature, provided we could get some guidance from contributors (we are new to this codebase).

@MartinThoma
Copy link
Member

This month we had / have a lot of changes. Only today most of them were merged back to main.

What kind of advice are you looking for?

@pubpub-zz
Copy link
Collaborator

Another project pyHanko seems to propose such feature which may not be so easy to implement after a quick look at pdf 1.7
Does it worth to implement it ?

@MartinThoma
Copy link
Member

Very good point @pubpub-zz - let's discuss this with them as well: MatthiasValvekens/pyHanko#127

I wouldn't be a huge fan of introducing more dependencies and it looks very much to me that it's possible / simple to just exclude digital signatures from PyPDF2 without a real drawback for users.

@MartinThoma MartinThoma added the PdfWriter The PdfWriter component is affected label Jul 9, 2022
@MartinThoma
Copy link
Member

I gave this another thought: I like the feature, but I also don't see the need to add it directly to PyPDF2. We have a couple of other topics/bugs in PyPDF2 which we should improve and pyHanko could be used in combination with PyPDF2.

For that reason, I would close this issue as "not in 2022". If anybody still feels we need it, we can open it in 2023 again. Are there any objections?

@MartinThoma
Copy link
Member

I'm closing this as a duplicate of #302

@MartinThoma MartinThoma changed the title Digitally sign PDF document ENH: Digitally sign PDF document May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-feature A feature request PdfWriter The PdfWriter component is affected
Projects
None yet
Development

No branches or pull requests

4 participants