Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add tests for utils #827

Merged
merged 6 commits into from
Apr 26, 2022
Merged

TST: Add tests for utils #827

merged 6 commits into from
Apr 26, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@MartinThoma MartinThoma force-pushed the test-utils branch 2 times, most recently from 2454673 to 72455b5 Compare April 26, 2022 18:32
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #827 (ad7e0b8) into main (355f805) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head ad7e0b8 differs from pull request most recent head f79eba2. Consider uploading reports for the commit f79eba2 to get more accurate results

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   77.00%   77.19%   +0.18%     
==========================================
  Files          12       12              
  Lines        3523     3525       +2     
  Branches      821      822       +1     
==========================================
+ Hits         2713     2721       +8     
+ Misses        594      588       -6     
  Partials      216      216              
Impacted Files Coverage Δ
PyPDF2/merger.py 68.07% <ø> (ø)
PyPDF2/filters.py 74.01% <100.00%> (ø)
PyPDF2/generic.py 67.84% <100.00%> (ø)
PyPDF2/pdf.py 82.15% <100.00%> (+0.14%) ⬆️
PyPDF2/utils.py 93.64% <0.00%> (+2.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355f805...f79eba2. Read the comment docs.

@MartinThoma MartinThoma merged commit f90a9d7 into main Apr 26, 2022
@MartinThoma MartinThoma deleted the test-utils branch April 26, 2022 20:20
MartinThoma added a commit that referenced this pull request Apr 28, 2022
getFormTextFields now return an empty dict instead of throwing an exception if no form fields are found. This should eliminate an error source
VictorCarlquist pushed a commit to VictorCarlquist/PyPDF2 that referenced this pull request Apr 29, 2022
getFormTextFields now return an empty dict instead of throwing an exception if no form fields are found. This should eliminate an error source
MartinThoma added a commit that referenced this pull request May 1, 2022
Robustness (ROB):
-  Handle missing destinations in reader (#840)
-  warn-only in readStringFromStream (#837)
-  Fix corruption in startxref or xref table (#788 and #830)

Documentation (DOC):
-  Project Governance (#799)
-  History of PyPDF2
-  PDF feature/version support (#816)
-  More details on text parsing issues (#815)

Developer Experience (DEV):
-  Add benchmark command to Makefile
-  Ignore IronPython parts for code coverage (#826)

Maintenance (MAINT):
-  Split pdf module (#836)
-  Separated CCITTFax param parsing/decoding (#841)
-  Update requirements files

Testing (TST):
-  Use external repository for larger/more PDFs for testing (#820)
-  Swap incorrect test names (#838)
-  Add test for PdfFileReader and page properties (#835)
-  Add tests for PyPDF2.generic (#831)
-  Add tests for utils, form fields, PageRange (#827)
-  Add test for ASCII85Decode (#825)
-  Add test for FlateDecode (#823)
-  Add test for filters.ASCIIHexDecode (#822)

Code Style (STY):
-  Apply pre-commit (black, isort) + use snake_case variables (#832)
-  Remove debug code (#828)
-  Documentation, Variable names (#839)

Full Changelog: 1.27.9...1.27.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant