Add PageObject to __init__.py
#960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #960 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 18 18
Lines 4080 4080
Branches 858 858
=======================================
Hits 3442 3442
Misses 451 451
Partials 187 187
Continue to review full report at Codecov.
|
|
@xilopaint what do you need the page object for? Why do you need to import it? |
|
I need it for using the |
|
Nice! Thank you for explaining it - makes sense to me :-) It will be part of the next release. It's not yet planned when this will be, but some time this month for sure :-) (in the current pace rather this week 😅 ) |
MartinThoma
added a commit
that referenced
this pull request
Jun 12, 2022
New Features (ENH): - Add support for pathlib as input for PdfReader (#979) Performance Improvements (PI): - Optimize read_next_end_line (#646) Bug Fixes (BUG): - Adobe Acrobat \'Would you like to save this file?\' (#970) Documentation (DOC): - Notes on annotations (#982) - Who uses PyPDF2 - intendet \xe2\x9e\x94 in robustness page (#958) Maintenance (MAINT): - pre-commit / requirements.txt updates (#977) - Mark read_next_end_line as deprecated (#965) - Export `PageObject` in PyPDF2 root (#960) Testing (TST): - Add MCVE of issue #416 (#980) - FlateDecode.decode decodeParms (#964) - Xmp module (#962) - utils.paeth_predictor (#959) Code Style (STY): - Use more tuples and list/dict comprehensions (#976) Full Changelog: 2.1.0...2.1.1
pubpub-zz
added a commit
to pubpub-zz/pypdf
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, accessing the
PageObject.create_blank_pagestatic method depends on importingPageObjectwith something likefrom PyPDF2._page import PageObject. It feels weird as the leading underscore indicates that the_pagemodule should not be imported directly.This PR adds
PageObjectto__init__.pyallowing it to be imported in a cleaner way withfrom PyPDF2 import PageObject.