Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Annotate angle parameter of page.rotate with int instead of float #1092

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

MartinThoma
Copy link
Member

Closes #1021

Co-authored-by: probel_hero 93727145+SXHRYU@users.noreply.github.com

Closes #1021

Co-authored-by: probel_hero <93727145+SXHRYU@users.noreply.github.com>
@MartinThoma MartinThoma changed the title MAINT: Set page.rotate(angle: int) MAINT: Annotate angle parameter of page.rotate with int instead of float Jul 10, 2022
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #1092 (6623fe8) into main (e51141d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          24       24           
  Lines        4546     4546           
  Branches      933      933           
=======================================
  Hits         4164     4164           
  Misses        241      241           
  Partials      141      141           
Impacted Files Coverage Δ
PyPDF2/_page.py 92.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51141d...6623fe8. Read the comment docs.

@MartinThoma MartinThoma merged commit c5c0b55 into main Jul 10, 2022
@MartinThoma MartinThoma deleted the int-annotation-rotate branch July 10, 2022 14:02
MartinThoma added a commit that referenced this pull request Jul 10, 2022
New Features (ENH):
-  Add PageObject._get_fonts (#1083)
-  Add support for indexed color spaces / BitsPerComponent for decoding PNGs (#1067)

Performance Improvements (PI):
-  Use iterative DFS in PdfWriter._sweep_indirect_references (#1072)

Bug Fixes (BUG):
-  Let Page.scale also scale the crop-/trim-/bleed-/artbox (#1066)
-  Column default for CCITTFaxDecode (#1079)

Robustness (ROB):
-  Guard against None-value in _get_outlines (#1060)

Documentation (DOC):
-  Stamps and watermarks (#1082)
-  OCR vs PDF text extraction (#1081)
-  Python Version support
-  Formatting of CHANGELOG

Developer Experience (DEV):
-  Cache downloaded files (#1070)
-  Speed-up for CI (#1069)

Maintenance (MAINT):
-  Set page.rotate(angle: int) (#1092)
-  Issue #416 was fixed by #1015 (#1078)

Testing (TST):
-  Image extraction (#1080)
-  Image extraction (#1077)

Code Style (STY):
-  Apply black
-  Typo in Changelog

Full Changelog: 2.4.2...2.4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant