DEP: overwriteWarnings parameter of reader/merger #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`. The new behavior is `overwriteWarnings=False`. Additionally, PyPDF2.utils.formatWarning was removed
MartinThoma
force-pushed
the
drop-overwrite-warnings
branch
from
1882178
to
1503b95
Compare
Codecov Report
@@ Coverage Diff @@
## 2.0.0-dev #846 +/- ##
=============================================
+ Coverage 82.07% 82.11% +0.04%
=============================================
Files 15 15
Lines 3649 3635 -14
Branches 780 777 -3
=============================================
- Hits 2995 2985 -10
+ Misses 489 487 -2
+ Partials 165 163 -2
Continue to review full report at Codecov.
|
MartinThoma
added a commit
that referenced
this pull request
May 2, 2022
PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`. The new behavior is `overwriteWarnings=False`. Additionally, PyPDF2.utils.formatWarning was removed
MartinThoma
added a commit
that referenced
this pull request
May 2, 2022
PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`. The new behavior is `overwriteWarnings=False`. Additionally, PyPDF2.utils.formatWarning was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PdfFileReader and PdfFileMerger no longer have the
overwriteWarnings.The new behavior is
overwriteWarnings=False.Additionally, PyPDF2.utils.formatWarning was removed