Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PdfFileMerger deprecation warning tells to use "PdfMerge" instead of "PdfMerger" #1106

Closed
T4m opened this issue Jul 14, 2022 · 4 comments
Closed

PdfFileMerger deprecation warning tells to use "PdfMerge" instead of "PdfMerger" #1106

T4m opened this issue Jul 14, 2022 · 4 comments
Labels
Easy This issue is a good starting point for first-time contributors help wanted We appreciate help everywhere - this one might be an easy start!

Comments

@T4m
Copy link

T4m commented Jul 14, 2022

After a dependencies updates, I got the following warning in the console :

PendingDeprecationWarning: PdfFileMerger is deprecated and will be removed in PyPDF2 3.0.0. Use PdfMerge instead.

"PdfMerge" actually doesn't exist in this library. The message is supposed to state PdfMerger (with an r)

Place of the bug: PyPDF2._utils.deprecate_with_replacement
@MartinThoma
Copy link
Member

Thank you for reporting! Do you want to make a small pr fixing this?

@MartinThoma
Copy link
Member

You can look for the line deprecate_with_replacement("PdfFileMerger", "PdfMerge").

@MartinThoma MartinThoma added Easy This issue is a good starting point for first-time contributors help wanted We appreciate help everywhere - this one might be an easy start! labels Jul 20, 2022
@pubpub-zz pubpub-zz mentioned this issue Jul 24, 2022
Merged
@pubpub-zz
Copy link
Collaborator

new goal : less thant 75 issues open!😁

@MartinThoma
Copy link
Member

MartinThoma commented Jul 24, 2022 •
edited

My next goal is to close/merge those PRs from before April 2022 😄

Similarly for the issues: I want to get rid of the really old stuff. I recently started to close issues that didn't have a PDF / code to reproduce. They have very little chance of ever getting closed + they cost energy to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy This issue is a good starting point for first-time contributors help wanted We appreciate help everywhere - this one might be an easy start!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinThoma @T4m @pubpub-zz