Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major book refactoring and revision #33

Merged
merged 12 commits into from Feb 17, 2021
Merged

Major book refactoring and revision #33

merged 12 commits into from Feb 17, 2021

Conversation

TomasBeuzen
Copy link
Collaborator

@TomasBeuzen TomasBeuzen commented Feb 4, 2021

This PR includes:

@TomasBeuzen TomasBeuzen self-assigned this Feb 4, 2021
@ttimbers
Copy link
Collaborator

When are you planning on merging this PR? I am going to heavily use this book for teaching after reading week and I need to get the links in order for the course a bit before then. Also, do you need my review on this?

@TomasBeuzen
Copy link
Collaborator Author

@ttimbers not planning on merging anytime soon, like 2-3 months, (also won't need reviews until then), I'm going to keep developing here and then branch off this PR too. So you can go ahead and refer to the book as it is for the upcoming course.

@ttimbers
Copy link
Collaborator

But will the students miss all your new good things then?

@TomasBeuzen
Copy link
Collaborator Author

TomasBeuzen commented Feb 11, 2021

Okay - change of plan. I'll finish refactoring and will merge this by the end of the week (this will push the new directory/site structure). Then I'll continue developing chapter-by-chapter with new PRs and will push when they're ready (these won't change the structure, just the content, so your links should be fine).

@TomasBeuzen
Copy link
Collaborator Author

TomasBeuzen commented Feb 12, 2021

@ttimbers - this is almost ready to go (I'll merge later today or on Tuesday after a final read-through). This PR includes:

  • General structural changes to book and repo
  • Add a preface and introduction
  • Move some chapters to appendices

At this point, I won't be changing the structure of the book/repo anymore, I'll just be updating or adding to it. But feel free to see the netlify preview below. So any links you make should be good. You don't need to review any of the new material yet (preface, introduction, setup) as I would classify them as still WIP and will make separate PRs when I'm ready for them to be reviewed. I will note that I added our pictures and a short bio here. LMK if you don't want your picture there - we can edit the bios when I make a separate PR for that section?

@TomasBeuzen TomasBeuzen marked this pull request as ready for review February 15, 2021 16:45
@TomasBeuzen
Copy link
Collaborator Author

@ttimbers - this is ready to merge. The only thing I'll note is that I significantly shortened the "RStudio setup" section. As this is going to be a text book I'd like it to stay relevant for as long as possible, so I'm trying to remove highly specific instructions like we had, and instead refer readers to the relevant documentation.

@ttimbers
Copy link
Collaborator

Sounds good to me! Thanks for pushing this refactoring, I am going to merge now as I am needing to get the links for the course today.

@ttimbers ttimbers merged commit e6d5f43 into master Feb 17, 2021
@TomasBeuzen TomasBeuzen deleted the refactor branch February 18, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Introduction Add acknowledgements section Add vscode and jupyterlab to "1.3. Python IDEs"
2 participants