LukeMS's port of the PyGame time API to sdl2 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeMS has this added to his personal sdl2 repo on GitHub, but hasn't offered the patch upstream. Enough people seem to want it that I've decided ti offer it as a PR. I didn't take time to write unit tests for it, sorry. Closes py-sdl#168.
|
@iKarith Thanks so much for the PR! Sorry for not getting around to this sooner, I've been super-busy with various time-sensitive academic projects. I'll try to review this properly this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LukeMS has this added to his personal sdl2 repo on GitHub, but hasn't
offered the patch upstream. Enough people seem to want it that I've
decided ti offer it as a PR. I didn't take time to write unit tests for
it, sorry. Closes #168.
I've stopped using this code, instead preferring to let my update loop run as often as it does and keep track of elapsed ticks. When enough have passed for something to happen, I do it. But this API provides the simplicity of the PyGame API in this respect because it duplicates that API pretty exactly.