Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2.ext.draw.fill: area should be able to be SDL_Rect #169

Closed
knghtbrd opened this issue Nov 2, 2020 · 3 comments
Closed

sdl2.ext.draw.fill: area should be able to be SDL_Rect #169

knghtbrd opened this issue Nov 2, 2020 · 3 comments
Assignees
Labels

Comments

@knghtbrd
Copy link

knghtbrd commented Nov 2, 2020

If I set area to be a tuple, I get the correct fill. If I set it to SDL_Rect with the same contents, what I get is the entire surface filled.

Using 0.9.4 on Linux Mint 20 (Ubuntu Focal base). I'll fix my code—I intended this to be temporary code anyway.

@a-hurst
Copy link
Member

a-hurst commented Dec 18, 2020

Hey, sorry, for some reason I haven't been getting notifications for new issues! I'll make some time to tackle your issues and your PR soon, though that might not be until late this month as I have other projects that need work. Thanks for helping make this package better!

@a-hurst a-hurst self-assigned this Dec 27, 2020
@a-hurst a-hurst added the bug label Dec 27, 2020
@a-hurst
Copy link
Member

a-hurst commented Dec 27, 2020

This seems like an easy fix, I'll add this after the 2.0.14 updates are done!

@a-hurst
Copy link
Member

a-hurst commented Jul 23, 2021

@iKarith Sorry for the delay, finally fixed as of this commit! 32b81f4

@a-hurst a-hurst closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants