Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of engine parameters no longer used #58

Open
johndoknjas opened this issue Aug 1, 2023 · 0 comments
Open

Get rid of engine parameters no longer used #58

johndoknjas opened this issue Aug 1, 2023 · 0 comments

Comments

@johndoknjas
Copy link

The self._parameters dict has a few options that don't appear in current Stockfish's options list. Namely:

  • "Contempt" - removed from the Stockfish source in commit ed436a3, on June 16, 2021.
  • "Min Split Depth" - removed from the Stockfish source in commit 307a5a4, on Oct 24, 2015.
  • "Minimum Thinking Time" - removed from the Stockfish source in commit 208c53d, on June 24, 2020.

Continuing to call the stockfish engine with setoption for any of these won't crash the engine. In the terminal it simply says it's not an option, and continues running fine. However, having the user believe these are still options in use of course isn't good. Removing a recent option could be unideal though, if a user is using a version of Stockfish that still had that option.

A middleground would be adjusting self._parameters based off the version of Stockfish the user is using, but maybe this introduces too much complexity into the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant