Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove win32tz.py ? #34

Open
da4089 opened this issue Mar 27, 2024 · 2 comments
Open

Remove win32tz.py ? #34

da4089 opened this issue Mar 27, 2024 · 2 comments
Milestone

Comments

@da4089
Copy link

da4089 commented Mar 27, 2024

The vobject package includes support for obtaining timezone information from the Windows registry, implemented in the win32tz.py file. It is not imported by any of the other vobject source files: it appears to have been provided basically as a helpful facility if needed by a client application.

This file looks like it has never been ported to Python 3: it imports _winreg (renamed to winreg in 3.0), and uses xrange() (without six.moves), for example.

It seems also that dateutil provides equivalent functionality from version 2.5.0, which I imagine is much better maintained.

With the change to API v1.0, this file could be removed, with a recommendation to switch to using dateutil instead. This would need an assessment of whether there's actually anything unique about what is implemented, vs. what's in dateutil.

@da4089 da4089 added this to the v1.0 milestone Mar 27, 2024
@da4089
Copy link
Author

da4089 commented Apr 1, 2024

I guess really it should be deprecated, rather than removed.

@return42
Copy link

return42 commented Apr 1, 2024

I think it can be removed .. at least this module is not py3 compatible --> return42@35e3ccf532#diff-16a068e726d774b7e02c57fdbaea48a806343fcbc18e032c9ee5995bf45ced07R1-R5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants