Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing domain knowledge #4

Closed
dg46 opened this issue Nov 19, 2021 · 5 comments
Closed

Passing domain knowledge #4

dg46 opened this issue Nov 19, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@dg46
Copy link

dg46 commented Nov 19, 2021

I am planning to get rid of Java dependencies in cause2e by replacing py-causal with causal-learn for the discovery step.

However, my applications require passing domain knowledge in the form of required or forbidden edges in the causal graph. Py-causal and Tetrad have a great interface for domain knowledge. Will this be included in causal-learn, too? In the docs, I have only found possibilities for LiNGAM-type models, but not for GES or PC.

Thanks for finally translating Tetrad to Python!

@dg46
Copy link
Author

dg46 commented Nov 19, 2021

Oops, found it for PC. Must have overlooked it, sorry. I will try this out, but it would still be helpful to have the functionality for other algorithm types.

@kunwuz
Copy link
Collaborator

kunwuz commented Nov 19, 2021

Thanks for your feedback. Cause2e is a fantastic package! :)

In the future, we will include 'background_knowledge' for other methods. We will update you when these functions are available. Thanks for your interest in causal-learn!

@kunwuz kunwuz added the enhancement New feature or request label Nov 19, 2021
@dg46
Copy link
Author

dg46 commented Nov 22, 2021

Thanks a lot for the quick reply, sounds great!

@kunwuz
Copy link
Collaborator

kunwuz commented Dec 16, 2021

Hi @dg46, just a quick update :) We've re-implemented FCI. Now it includes the background_knowledge. Also, the speed of FCI has been improved a lot.

@dg46
Copy link
Author

dg46 commented Dec 17, 2021

Thank you for the update, I will give it a try!

@kunwuz kunwuz closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants