Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP, ENH] Add wrapper for Causica algorithm #99

Closed
wants to merge 2 commits into from
Closed

[WIP, ENH] Add wrapper for Causica algorithm #99

wants to merge 2 commits into from

Conversation

robertness
Copy link
Collaborator

@robertness robertness commented Jan 21, 2023 •
edited by adam2392

Fixes #100

Changes proposed in this pull request:

  • Adds a wrapper to Causica, which uses variational inference on a nonlinear additive model.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

adam2392
adam2392 reviewed Jan 26, 2023
View reviewed changes
dodiscover/scm/causica.py
self,
data: pd.DataFrame,
context: Context,
training_options: dict,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of keeping fit API as fit(data, context) and any model options within the initialization. Keeps consistent across the different models

@robertness
Copy link
Collaborator Author

Closing as causica is doing a refactor. May reopen later.

@robertness robertness closed this Apr 6, 2023
@adam2392 adam2392 deleted the causica branch July 17, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a wrapper to Causica SCM discovery algorithm
2 participants
@robertness @adam2392