Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-singleton treatment/outcome sets to "has_directed_path" method #654

Open
emrekiciman opened this issue Sep 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@emrekiciman
Copy link
Member

emrekiciman commented Sep 21, 2022

The logic of checking "has_directed_path", as used in AutoIdentifier.py::identify_effect() is that it is an early sanity check that the caller is asking a sensible question. I.e., if a variable X has no way of influencing Y according to the causal graph, then it doesn't make sense to do a fancy calculation to give you the same response. It's perhaps more likely that the caller is making a mistake somewhere and we want to call that out.

it only supports singleton treatment and outcome sets, but might be called with sets that have greater cardinality

So, if we have a higher cardinality, I can see two options:
(1) a minimum requirement would be that at least one of the treatments has a direct path to at least one of the outcomes.
(2) more aggressively: every one of the treatments has at least one direct path to one of the outcomes. And, every one of the outcomes has a direct path from at least one of the treatments.

I'd probably go for #2

Originally posted by @emrekiciman in #640 (comment)

@petergtz petergtz added the enhancement New feature or request label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants