Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder methods? #78

Closed
jrfiedler opened this issue Oct 19, 2019 · 1 comment · Fixed by #80
Closed

Placeholder methods? #78

jrfiedler opened this issue Oct 19, 2019 · 1 comment · Fixed by #80

Comments

@jrfiedler
Copy link
Contributor

Base classes sometimes have placeholder methods that raise a NotImplementedError (for example, CausalEstimator._do), and sometimes they don't (for example, CausalEstimator seems to rely on a method _estimate_effect, but that doesn't have a placeholder method).

Do you generally want the placeholder methods? If so, I can work on finding them and filling them in.

@amit-sharma
Copy link
Member

@jrfiedler yes, that's a good idea on adding the placeholders and being consistent. Feel free to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants