Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMT input Python files are not valid Python #568

Open
jayvdb opened this issue Jan 3, 2024 · 1 comment
Open

SMT input Python files are not valid Python #568

jayvdb opened this issue Jan 3, 2024 · 1 comment
Labels

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 3, 2024

The only valid input Python test case files for the SMT transpiler are

None of these files do anything useful in Python, and are all invalid test cases for all of the other transpilers.

I have attempted to make them valid Python files, and mostly succeeded, in #513 , which makes them use https://github.com/jayvdb/smtfe , but that project is a long way from being useful, and I am no longer using Python enough to make it worthwhile me pursuing alone.

As a result, I suggest that we repurpose the SMT transpiler as an example of how to create a transpiler using the new py2many.registry system.

i.e. pysmt would not be part of the py2many installed package. Instead it would be revised slightly to be a separate non-published package that uses py2many as a library. It would be removed from test_cli and test_unsupported. I am happy to create a new the test system for it so it doesnt regress, and that CI would only run when there are changes to its special inputs or its code.

@adsharma
Copy link
Collaborator

It makes sense to move smt to a different class of backends vs the others.

If you try to make the files valid python, you end up with sympy with all its gotchas.

By giving up on making it valid python and using transpilation approach instead, we end up with simpler, more approachable syntax for someone familiar with python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants