Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACOM_03_Au_NP_sim.ipynb bugs #11

Open
sezelt opened this issue Feb 11, 2022 · 0 comments
Open

ACOM_03_Au_NP_sim.ipynb bugs #11

sezelt opened this issue Feb 11, 2022 · 0 comments

Comments

@sezelt
Copy link
Member

sezelt commented Feb 11, 2022

Running the ACOM_03 notebook as downloaded, cell 25 gives the following error:

---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
/var/folders/ts/tq6v7mks7hvg37ys5zvs1c2w0000gn/T/ipykernel_3012/3733081456.py in <module>
     14 
     15 # Fit an ellipse to the elliptically corrected bvm
---> 16 qx0_corr,qy0_corr,a_corr,e_corr,theta_corr = py4DSTEM.process.calibration.fit_ellipse_1D(bvm_ellipsecorr,(qx0,qy0),(qmin,qmax))
     17 
     18 py4DSTEM.visualize.show_elliptical_fit(

NameError: name 'qmin' is not defined

I think someone changed qmin, qmax to be a list called qrange and never actually tested the notebook in a fresh state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant