Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder dev #2

Merged
merged 12 commits into from Jun 13, 2021
Merged

Binder dev #2

merged 12 commits into from Jun 13, 2021

Conversation

alex-rakowski
Copy link
Collaborator

  • Binder link created, currently lands in Index.ipynb
  • data loaded as part of the notebooks, running all cells on notebooks inside binder will work.
  • Added file_getter.py which takes command-line arguments, which makes extending the download to more notebooks fairly straightforward.
  • Both notebooks work, make_probe_templates.ipynb required adding some clean-up steps to avoid going over 2GB ram limit, the alternative is to split them into more separate notebooks.
  • There's a slight issue that if people don't shutdown notebooks properly or if they have multiple notebooks over, they may cause kernel panics, both notebooks peak memory usage push the 2GB limit .
  • I haven't given much attention to style or formatting currently just wanted to get something functional and working to see if works as required.

@bsavitzky bsavitzky merged commit a336f39 into dev Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants