Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink inline javascript for reports for JupyterLab compatibility #205

Open
sserita opened this issue Aug 25, 2021 · 0 comments
Open

Rethink inline javascript for reports for JupyterLab compatibility #205

sserita opened this issue Aug 25, 2021 · 0 comments
Labels
enhancement Request for a new feature or a change to an existing feature
Milestone

Comments

@sserita
Copy link
Contributor

sserita commented Aug 25, 2021

Is your feature request related to a problem? Please describe.
The current report workspaces heavily uses inline javascript for its interactive rendering. This works great in regular Jupyter notebooks, but JupyterLab silently suppresses the JS execution. If more users are moving towards JupyterLab, this is something we should provide an alternative for.

Describe the solution you'd like
Maintain the same level of display functionality as classic Jupyter notebooks in JupyterLab.

Describe alternatives you've considered

  • Try to find an extension/setting that reenables the current JS execution in JupyterLab, and require it for interactive report generation.
  • Rework the JS execution into something that is natively enabled in JupyterLab.

Not sure which is the easier solution yet. The former seems like less work in the PyGSTi codebase but may not be easy to find/require. More likely, we should make sure to keep this in mind the next time we spend significant effort on upgrading the reports.

Additional context
I have not searched exhaustively yet, but this thread is relevant: jupyterlab/jupyterlab#3118

@sserita sserita added the enhancement Request for a new feature or a change to an existing feature label Aug 25, 2021
@sserita sserita added this to the 0.9.14+ milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a new feature or a change to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant