Hi there I have modified some files #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi I have modified some files Some files like pattern and one password_generator has been modified. The files have been modified in order to flexibility and for running good. Some issues are found. Hope you like it and merge the valuable.
|
Sorry but other contributors have objection to modifying their files. Not Accepting this PR |
|
you please merge I will talk to them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have modified some files
Some files like pattern and one password_generator has been modified.
The files have been modified in order to flexibility and for running
good. Some issues are found.
Hope you like it and merge the valuable. Resolves issue #140