-
Notifications
You must be signed in to change notification settings - Fork 35
Physcraper: Automated phylogenetic updating #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Edited to new release (0.55), with some minor updates. |
Preprint posted at: https://www.biorxiv.org/content/10.1101/2020.09.15.299156v1 |
hi there @snacktavish i'm so sorry we have been out of communication here. are you still interested in a review by pyopensci? i've been a bit overwhelemed by current events which has been a hit at work in productivity. We may have an editor for this however if you are still interested in a review. |
Yes! We are still interested in a review by pyopensci, but we also understand if that isn't possible given the current situation. Thanks! |
Hi @snacktavish ! Currently I work in AI / neuro but my background is bio ... and one of the main reasons I made it into science is a really good prof who taught the first non-boring class I took, on bioinformatics where we worked on genome assembly, phylogenetics, and related things. So I think I get at a high level what One thing: since we are still relatively new, we don't have a huge pool of reviewers to draw from right now. I can think of some places to start asking, but do you by any chance have two people you could recommend as reviewers? |
thank you @NickleDave i'll list you as an editor here at the top!! and @snacktavish THANK YOU for your patience with us. Also you have the best GH handle ever :) |
Hey @snacktavish just want to check back -- please let me know if you need me to start looking for reviewers
and I agree with Leah that you have the best GitHub handle ever |
Sorry for the delay! I started thinking about it, and then forgot to respond. Folks that I think would be good reviewers, or could potentially suggest others who would be include @blackrim @josephwb @jfwalker (Contributors to https://github.com/FePhyFoFum/PyPHLAWD) @rvosa @DomBennett (Contibutors to SuperSmart https://academic.oup.com/sysbio/article/66/2/152/2418028). @LunaSare - any other suggestions? Thanks for the username love! When I first joined GitHub I didn't fully realize how much it would be part of my professional identity and was just like, hey, I like snacks! And now 10ish years later, lots of folks call me @snacktavish and I love it. 🍜 🍕 🍟 |
Thank you @snacktavish that likes snacks! The folks you tagged all sound like perfect reviewers. I think I would also like to try and find a third reviewer from outside those you (very helpfully) suggested as @lwasser has asked me to do on other reviews. |
HI there all!! i think IF you can have one that @snacktavish suggests and one outside reviewer (for a total of 2 reviewers) that would be perfect :) thank you so much Dave !!! |
Understood, thank you @lwasser |
@snacktavish @lwasser adding initial editor checks. Editor checks:
Editor comments
|
@snacktavish @LunaSare @lwasser just an update that I have started reaching out to potential reviewers |
update: reached out to a couple more reviewers 🤞 |
update update: very excited that @bpucker has accepted the invitation to review!!! 🎉🎉🎉 Boas, just a reminder that our reviewer guide is here: |
Package Review
DocumentationThe package includes all the following forms of documentation:
Readme requirements
The README should include, from top to bottom:
UsabilityReviewers are encouraged to submit suggestions (or pull requests) that will improve the usability of the package as a whole.
Functionality
Review Comments
Description: Ubuntu 18.04.2 LTS anaconda Command line client (version 1.7.2) physcraper_run.py -s pg_328 -t tree322 -r -tb -o chenopodia Traceback (most recent call last): Minor comments: There are formatting issue on https://physcraper.readthedocs.io/en/latest/physcraper_run.html involving
final output ree > final output tree cofniguration > configuration updtaed > updated (https://physcraper.readthedocs.io/en/latest/data_exploration.html) Genbank/genbank > GenBank (https://physcraper.readthedocs.io/en/latest/apidocs.html) It appears that there should be a link on the overview figure, but the pages does not exist: https://physcraper.readthedocs.io/en/latest/how_to_start.html# |
Thank you so much for the thorough review! |
yes 🙏 thank you very much @bpucker -- looks quite helpful @snacktavish creating issues and linking here is perfect, as was done in this previous review #20 (comment) I will keep looking for one more reviewer |
Hi all, just checking in here. |
Not impatient at all! We are still working on addressing the comments from the first review, and the lab is dealing with some covid related setbacks as well as the holidays. Thanks for all your work on this, and no rush. |
Ok, thank you for the quick reply. |
Hi @snacktavish and @LunaSare happy to report that @leomrtns has generously accepted our invitation to review @leomrtns for your convenience here are the links to our reviewer guide and review template: Given everything else that is going on, I have set a due date for this review of five weeks: March 1, 2021 As we discussed I think this should be okay given that the authors are still working through issues from the first review |
Thanks @lwasser !!! Yes looks like we can wrap things up. And a big thank you @leomrtns and @bpucker for your reviews and very valuable input. And thanks to @LunaSare and @snacktavish for responding so clearly that even a non-expert like me can follow what's going on. Seems like the pyOpenSci review has been helpful for |
🎉 (I know I just said thanks in the last comment but it's the language in our template and I like the smiling cat emoji) There are a few things left to do to wrap up this submission:
All -- if you have any feedback for us about the review process please feel free to share it here. We are always looking to improve our process and our documentation in the contributing-guide. We have also been updating our documentation to improve the process so all feedback is appreciated! |
Adding as a separate comment so I don't overwhelm anyone trying to read that checklist: @LunaSare looks like you already did a "pyOpenSci review" release? https://github.com/McTavishLab/physcraper/releases/tag/v0.6.1 -- I think you could do a "post-release" where you just add the badge to the README (sorry if I'm telling you something you already know). I am pretty sure that a Zenodo DOI is still the mechanism we use to track completed reviews though -- @lwasser please correct me if I'm wrong. @LunaSare you could just do a post release with the 5 more commits you have now, assuming you're okay with that. (Again sorry if I'm explaining something that's already obvious to you--I had to learn this stuff the hard way 😢 so I'm just trying to save you potential packaging pain (AKA PPP)). |
yay @NickleDave this is all awesome! and @LunaSare @snacktavish thank you for all of your work on this review and reviewers @bpucker @leomrtns thank you for your time in reviewing for us! @NickleDave yes great catch. one post release even if it is a patch with the badge in the readme is appreciated. then we can use that specific zenodo archive in the records here as the version we "approved". |
Hi @NickleDave and @lwasser! Thanks for the tips! This is the first time I am dealing with official package releases, so explanations are greatly appreciated. I'll give it a go and cry for help if needed! |
Ah ok. I might have made things extra confusing by bringing up PyPI. but, as long as I brought it up: But again I didn't mean to imply you need to deal with any of that to get the DOI so we can finish up review. |
@LunaSare are you interested in pushing to pypi? i think it is ideal and we could likely help you through it and take notes on any pain points. i have a setup for our packages where it gets pushed when there is a new release using github actions. But first we would need to know who originally pushed this to pypi so we can get credentials figured out and such and help from there to ensure there is only ONE version of it on pypi! |
We created a v1.0.0 release updated the PyPi version! We also did these:
|
Thanks so much @lwasser and @NickleDave for the helpful guidance! @NickleDave, we ended up releasing v1.0.0 of Physcraper. Thanks for teaching us about post-releases, I think it will save us some headaches in the future! Also, the guide to make code citable was super useful! |
Excellent, @lwasser and I are very glad we could help. It's official!!! Just merged in the PRs. Thank you all again! |
hey 👋 @snacktavish @NickleDave @bpucker @leomrtns ! I hope that you are all well. I am reaching out here to all reviewers and maintainers about pyOpenSci now that i am working full time on the project (read more here). We have a survey that we'd like for you to fill out so we can:
NOTE: this is different from the form designed for reviewers to sign up to review. Thank you in advance for doing this and supporting pyOpenSci. |
hi 👋 @snacktavish and @bpucker ! just a friendly reminder to take 5-10 minutes to fill out our survey . We really appreciate it. Emily, if you can have all of the maintainers of your package fill it out that would be great. We will stay in touch with package authors - checking in 1-2 times a year to ensure the package continues to be maintained and see better understand challenges that you face. It's important for us to be able to stay in touch with the package maintenance crew! We also want to list everyone on our website as maintainers. Thank you in advance for helping us by filling out the survey!! 🙌 |
hey there @bpucker thank you so much for filling out our survey! ✨ |
hey @snacktavish ! i'm just checking in. we do need to ensure that packages are still being maintained that have been accepted to pyopensci. I see that hte last commit to physcraper was in May of this year which is great! Is this package still being maintained? And can you kindly also fill out our maintainer survey. we need to be able to keep in touch with our maintainers to ensure packages remain supported in our ecosystem. All the best! |
Hi Leah, |
hi @snacktavish !! thank you so so much! no worries on the response. I"m excited to know it's still maintained and appreciate you both filling it out! Are you the only two maintainers of the package? 🙌 |
We are! |
Awesome. Thanks so much for the speedy replies today!
Leah
Leah A Wasser
Executive Director, pyOpenSci
@leahawasser
@pyOpenSci
***@***.***
… On Oct 19, 2022, at 2:48 PM, Emily Jane McTavish ***@***.***> wrote:
We are!
—
Reply to this email directly, view it on GitHub <https://www.google.com/url?q=https://github.com/pyOpenSci/software-review/issues/26%23issuecomment-1284556323&source=gmail-imap&ust=1666817304000000&usg=AOvVaw1WtYFrKHBFZE8SWJG0hz-1>, or unsubscribe <https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/AB2LPKVKUAPUN3JQ54OH62DWEBNBPANCNFSM4O3CRLWQ&source=gmail-imap&ust=1666817304000000&usg=AOvVaw195IQFFhKOuv9D0Le9KQ9W>.
You are receiving this because you were mentioned.
|
I submitted my answers to the survey |
Thank you @LunaSare! And thank you for the rare use of |
the rare DITTO to what David wrote! @LunaSare thank you so so much! I will be following up via email this week :) |
hey there @snacktavish @LunaSare i have another followup question. we are trying to grasp who "owns" or runs the maintainer team here vs who has contributed etc I have another name on my list Martha Kandziora and martha seemed to contribute in 2019 but i don't see any recent commits from them. Is it safe to say that Martha is no longer a maintainer? I am just trying to ensure our data are up to date. Many thanks |
Submitting Author: Emily Jane McTavish (@snacktavish)
All current maintainers: Emily Jane McTavish (@snacktavish), Luna L. Sanchez Reyes (@LunaSare)
Package Name: Physcraper
One-Line Description of Package: Automated phylogenetic updating
Repository Link: https://github.com/McTavishLab/physcraper
Version submitted: 0.55
Editor: @NickleDave
Reviewer 1: @bpucker
Reviewer 2: @leomrtns
Archive:
JOSS DOI: N/A
Version accepted: v 1.0
Date accepted (month/day/year): 09/14/2021
Description
Physcraper is an open‐source, command-line Python program that automatizes the update of published
phylogenies by enriching underlying gene alignments with public DNA sequence data, and linking taxonomic information across databases.
Scope
* Please fill out a pre-submission inquiry before submitting a data visualization package. For more info, see this section of our guidebook.
This package retrieves data from GenBank (https://www.ncbi.nlm.nih.gov/genbank/), the OpenTreeofLife (www.opentreeoflife.org), and TreeBase (www.treebase.org/), and links these datasets together to incorporate new sequence data into evolutionary estimates. Physcraper also provides a framework for comparison of published phylogenies with their updated versions, by using the conflict API of the Open Tree of Life project.
Physcraper can be used by the nonspecialist, as a tool to generate phylogenetic hypotheses based on already available expert phylogenetic knowledge.
Phylogeneticists and taxonomic group specialists will find it useful as a tool to facilitate molecular dataset gathering and comparison of alternative phylogenetic hypotheses.
The closest analogue in python is PyPhlawd https://fephyfofum.github.io/PyPHLAWD/.
This approach differs from other tools (PyPhlawd, Supersmart) automatize the assembly of DNA alignments from the GenBank database for phylogenetic reconstruction, in that Physcraper leverages existing homology statements in the form of alignments and existing phylogenetic trees to select appropriate loci and improve inference.
Another key feature of Physcraper is linking of taxonomic identifiers across databases including NCBI, GBIF and OpenTree of Life which provides easy interoperability with those resources, and the ability to easily compare relationships between new inferences and existing taxonomy and previously published studies.
@tag
the editor you contacted:No pre-submission inquiry
Technical checks
For details about the pyOpenSci packaging requirements, see our packaging guide. Confirm each of the following by checking the box. This package:
Publication options
JOSS Checks
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Note: Do not submit your package separately to JOSS
Are you OK with Reviewers Submitting Issues and/or pull requests to your Repo Directly?
This option will allow reviewers to open smaller issues that can then be linked to PR's rather than submitting a more dense text based review. It will also allow you to demonstrate addressing the issue via PR links.
Code of conduct
P.S. Have feedback/comments about our review process? Leave a comment here
Editor and Review Templates
Editor and review templates can be found here
The text was updated successfully, but these errors were encountered: