Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Token Import From a Pickle File Import to a Simple Text File #23

Conversation

bbulpett
Copy link
Contributor

@bbulpett bbulpett commented Apr 24, 2023

What was done


Addressing issue #21

  • Updated the code in parse_review_issues.py to import a txt file and populate the API_TOKEN variable rather than using a pickle.
  • Created a small helper function in the pyosmet src/file_io.py to import the parse the text file.
  • Updated the code in all three scripts as well to use the txt file rather than the pickle file
    -- parse_review_issues.py
    -- parse-contributors.py
    -- update_reviewers.py
  • Updated the .gitignore file to ensure the txt file is never populated into git history
  • Updated README.md with instructions in creating the token and storing it for use.

How to test


  • Run the workflow (particularly parse_review_issues.py) and review the output file (package.yml).
  • Ensure that no error is encountered related to the token or token file.

...

Special thanks to the team at PyCon 2023 for making this possible, with their help and encouragement! Thank you especially to @lwasser.

…-text-file' of github.com:bbulpett/update-web-metadata into move-token-import-from-a-pickle-file-import-to-a-simple-text-file
@bbulpett
Copy link
Contributor Author

pre-commit.ci autofix

@lwasser
Copy link
Member

lwasser commented Apr 24, 2023

this pr looks great!! thank you @bbulpett !! checking it out now locally and then will merge!

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! merging now!

@lwasser lwasser merged commit c00ae9b into pyOpenSci:main Apr 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants