Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extends PR from issue: #21 #24

Merged
merged 5 commits into from May 4, 2023
Merged

This extends PR from issue: #21 #24

merged 5 commits into from May 4, 2023

Conversation

paajake
Copy link
Contributor

@paajake paajake commented Apr 30, 2023

This PR provides an extension to the PR for issue #21 and contains some improvements for the initial project setup and project dependencies management by;

  • Cleaning up the requirements.txt and adding required dependencies
  • Integrating a .env file and usage for ALL project variables configuration
  • Adding a check for successful API requests
  • Updates README.md

How to Test

  • Follow the updated README.md to setup the project.
  • Run a project script and ensure NO errors are reported.

Thanks

- Cleans up requirements.txt and adds required dependencies
- Integrates .env file and usage
- Adds check for successful API request
- Updates README.md
@paajake
Copy link
Contributor Author

paajake commented Apr 30, 2023

pre-commit.ci autofix

@lwasser
Copy link
Member

lwasser commented May 4, 2023

hey there @paajake THANK YOU for this pr!! wow! will look at it now. And so good to meet you at pycon us this year!

@lwasser
Copy link
Member

lwasser commented May 4, 2023

@all-contributors please add @paajake for code, design, review

@allcontributors
Copy link
Contributor

@lwasser

I've put up a pull request to add @paajake! 🎉

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lwasser
Copy link
Member

lwasser commented May 4, 2023

pre-commit.ci autofix

@lwasser
Copy link
Member

lwasser commented May 4, 2023

This is a great addition / improvement. so many thanks for it @paajake !! merging now and i've added you to our contributors list for this repo!

@lwasser lwasser merged commit 4e42068 into pyOpenSci:main May 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants