New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor global optimizer #256

Open

gcattan opened this issue Mar 22, 2024 · 0 comments

Labels

Collaborator

gcattan commented Mar 22, 2024

pyRiemann-qiskit distance and mean methods take an additional parameter "optimizer", as compared to pyRiemann.

For these methods to be used within the pyRiemann MDM, we allow these methods to retrieve the "optimizer" from the global scope.

We can inherite from MDM inside pyRiemann-qiskit and change the signature of the methods used inside the MDM.

gcattan added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment