New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Dynamic URL #8
Comments
Need this very feature and, after digging into the code, it's just not possible to give parameters to a named route. |
@Arcesilas I have not thought of a solution yet, because I'm a bit out of time. But if you have a solution we can work on it and implement that package. I've done a PR about checking multiple URL's, the staff (@pyaesone17) is very receptive to suggestions. I will help in what I can do. Thanks |
Unfortunately, passing arguments for named route would introduce a BC change, since in the current version, the 2nd and 3rd arguments are used to override default configuration values of active and inactive state. But I'm still searching for a solution... |
Thanks you for your valuable suggestion. |
Hi, thanks for your answer. Would you mind if I propose a 2.0 version? It's required to be a new major version, since there would be breaking compatibility changes: I consider useless to pass other values for active and inactive states: when using well writen CSS, you use one class for that, period, just like Bootstrap does with |
Hi, I've started rewriting the package, for a possible v2.0. You can check it out here: https://github.com/arcesilas/active-state/tree/dev-v2 The readme has not been edited yet and the code has absolutely not been tested at all. It's not ready to be run, but it's ready to be read. The code is fully documented and the commits have explanatory log messages. Notes:
|
Latest commit seems to be functional. I still have some feature tests to write. Remaining to do:
|
Hi, me again... Finally got a final version, which may be tested on a Laravel installation. @pyaesone17 could you please have a look and tell me what you think? Is a PR worth considering? Note: since last message, I've changed the tests: ifXxxxxx tests now return active/inactive value and checkXxxxxxx tests return a boolean. It makes it more fluent when using in Blade templates, for example: |
Sorry for not replying briefly. How was that question? |
Finally, I made an independant fork, living on its own. |
Hello,
How can we do to check dynamic URLs?
example of route call:
{{ route('url', [$data->slug]) }}
The URL will change according to the dynamic slug.
Thank's
The text was updated successfully, but these errors were encountered: