Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for PytorchLightning >= 1.8 #1210

Merged
merged 4 commits into from Jan 20, 2023

Conversation

entn-at
Copy link
Contributor

@entn-at entn-at commented Dec 25, 2022

Adjust to PytorchLightning API changes in version 1.8.0. I did some testing to make sure nothing broke, including model training/finetuning and loading from pretrained/HF-hub; however, my tests likely didn't cover everything.

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 30.47% // Head: 30.47% // No change to project coverage 👍

Coverage data is based on head (befa186) compared to base (2a4e3bf).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1210   +/-   ##
========================================
  Coverage    30.47%   30.47%           
========================================
  Files           63       63           
  Lines         4040     4040           
========================================
  Hits          1231     1231           
  Misses        2809     2809           
Impacted Files Coverage Δ
pyannote/audio/cli/train.py 0.00% <0.00%> (ø)
...annote/audio/pipelines/voice_activity_detection.py 0.00% <ø> (ø)
pyannote/audio/core/model.py 81.01% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbredin hbredin merged commit cb7bfd5 into pyannote:develop Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants