Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding info about docker usage. #1454

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Expanding info about docker usage. #1454

merged 6 commits into from
Sep 7, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 5, 2022 •
edited

As the title.

Close #1453

image

@germa89 germa89 added the Documentation Documentation related (improving, adding, etc) label Sep 5, 2022
@germa89 germa89 added this to the v0.63.3 milestone Sep 5, 2022
@germa89 germa89 self-assigned this Sep 5, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited

Codecov Report

Merging #1454 (077f20d) into main (0fee35e) will not change coverage.
The diff coverage is n/a.

❗ Current head 077f20d differs from pull request most recent head 5ee34dd. Consider uploading reports for the commit 5ee34dd to get more accurate results

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   79.74%   79.74%           
=======================================
  Files          43       43           
  Lines        6799     6799           
=======================================
  Hits         5422     5422           
  Misses       1377     1377

akaszynski and others added 2 commits September 6, 2022 12:30
@akaszynski @PipKat
Apply suggestions from code review
330155e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@akaszynski @PipKat
Apply suggestions from code review
5ee34dd 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) September 7, 2022 08:41
@germa89 germa89 merged commit 17d4ebe into main Sep 7, 2022
@germa89 germa89 deleted the docs/expanding-docker-info branch September 7, 2022 09:27
germa89 added a commit that referenced this pull request Oct 11, 2022
@germa89 @akaszynski @PipKat
Expanding info about docker usage. (#1454)
8fc2fbe 
* Expanding info about docker usage.

* Small update.

* Cleaning

* Cleaning

* Apply suggestions from code review

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>

Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
germa89 added a commit that referenced this pull request Oct 11, 2022
@germa89
Revert "Expanding info about docker usage. (#1454)"
5c91036 
This reverts commit 8fc2fbe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski left review comments

@PipKat PipKat PipKat approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
v0.63.3
Development

Successfully merging this pull request may close these issues.

Add more content to docker documentation
3 participants
@germa89 @akaszynski @PipKat