Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small harmonic analysis improvements #1457

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Small harmonic analysis improvements #1457

merged 3 commits into from
Sep 7, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 6, 2022

Just adding frequency_values method.

@germa89 germa89 added the New Feature Request or proposal for a new feature label Sep 6, 2022
@germa89 germa89 added this to the v0.64.0 milestone Sep 6, 2022
@germa89 germa89 self-assigned this Sep 6, 2022
@germa89 germa89 mentioned this pull request Sep 6, 2022
Merged
@github-actions github-actions bot added the Enhancement Improve any current implemented feature label Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited

Codecov Report

Merging #1457 (2c2a7d8) into main (0fee35e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 2c2a7d8 differs from pull request most recent head d0a9a69. Consider uploading reports for the commit d0a9a69 to get more accurate results

@@            Coverage Diff             @@
##             main    #1457      +/-   ##
==========================================
+ Coverage   79.74%   79.80%   +0.05%     
==========================================
  Files          43       43              
  Lines        6799     6803       +4     
==========================================
+ Hits         5422     5429       +7     
+ Misses       1377     1374       -3

@akaszynski akaszynski enabled auto-merge (squash) September 7, 2022 00:54
@akaszynski akaszynski merged commit 65a30cc into main Sep 7, 2022
@akaszynski akaszynski deleted the feat/harmonic-analysis-improvements branch September 7, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
v0.64.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@germa89 @akaszynski