-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add converter entry point #1474
Conversation
Adding filename_out kwarg. Replacing ending line with "\n". Adding spacing between code parts.
Adding doc about exec_file argument in converter. Only raise an error if using default file name.
Codecov Report
@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
+ Coverage 80.32% 80.58% +0.25%
==========================================
Files 43 43
Lines 6779 6813 +34
==========================================
+ Hits 5445 5490 +45
+ Misses 1334 1323 -11 |
Pinging @RobPasMue @jorgepiloto for the note. |
convertscript is quite a generic name, the user should know that it's from pymapdl, right? |
Very good point. |
@akaszynski a preference? If we do this more in the future across pyansys libraries, should there be a convention? |
We should follow bash conventions. Google has a guide for this. I'd go underscores, not CAPS, avoid numbers. |
@akaszynski I was thinking more about the name and discovery of the command line program. SHould it be:
|
|
Changed to this. |
@koubaa could you review this PR? |
Add a command line interface for
mapdl.convert_script
.Close #1469
Note
I couldn't make it work for
[project.entry-points.(...)]
, not sure if because I was in editable mode (pip install -e .
) or because I was doing something wrong.I end up using
[project.scripts]
asansys-templates
library.Result