Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding links.rst to docs #1506

Merged
merged 21 commits into from
Oct 24, 2022
Merged

Adding links.rst to docs #1506

merged 21 commits into from
Oct 24, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 22, 2022

To centralize the links.

Related to: ansys/pyansys-dev-guide#70

Added checklink to make files. (Linux might need testing)

Close #1504

@germa89 germa89 marked this pull request as draft September 22, 2022 12:00
@github-actions github-actions bot added Documentation Documentation related (improving, adding, etc) BUG Issue, problem or error in PyMAPDL labels Sep 22, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1506 (9d407a8) into main (799829b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   82.11%   82.14%   +0.02%     
==========================================
  Files          43       43              
  Lines        6843     6843              
==========================================
+ Hits         5619     5621       +2     
+ Misses       1224     1222       -2     

@germa89
Copy link
Collaborator Author

germa89 commented Oct 24, 2022

Pinging @pyansys/pyansys-core for feedback. Specially @jorgepiloto

@germa89 germa89 mentioned this pull request Oct 24, 2022
3 tasks
@MaxJPRey MaxJPRey changed the title Adding links.rt to docs Adding links.rst to docs Oct 24, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 24, 2022
@germa89 germa89 marked this pull request as ready for review October 24, 2022 19:42
@germa89 germa89 merged commit 187ce6f into main Oct 24, 2022
@germa89 germa89 deleted the fix/documentation-links branch October 24, 2022 20:27
@RobPasMue
Copy link
Member

RobPasMue commented Oct 25, 2022

ansys/pyansys-dev-guide#82

I was going to redirect you to this PR :) since it seems to me that you are trying to do the same thing. But it looks like it's already merged. Sorry!

@germa89
Copy link
Collaborator Author

germa89 commented Oct 25, 2022

pyansys/dev-guide#82

I was going to redirect you to this PR :) since it seems to me that you are trying to do the same thing. But it looks like it's already merged. Sorry!

I know about that PR in fact, the idea came from it. However that PR is not completed and it seems stale. Further more I was told it has some PDF compilation problems.

I hope this one can inspire to finish the other one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc) Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links
2 participants