Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding edge case fix #1520

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Adding edge case fix #1520

merged 1 commit into from
Oct 11, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 29, 2022

I had a report where using:

nx = np.array(1)
mapdl.nsel("s","loc","x", nx)

will trigger the following error:

TypeError: len() of unsized object

And it due to the fact that numpy arrays made of single scalar don't support len() function.
This is a veeeery weird edge case, but yeah. Let's fix it.

@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature labels Sep 29, 2022
@germa89 germa89 self-assigned this Sep 29, 2022
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1520 (070a1ef) into main (157f0bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files          43       43           
  Lines        6784     6784           
=======================================
  Hits         5547     5547           
  Misses       1237     1237           

@germa89
Copy link
Collaborator Author

germa89 commented Sep 30, 2022

I still need to double check with Ansys lab team

@germa89
Copy link
Collaborator Author

germa89 commented Oct 11, 2022

LGTM.

@germa89 germa89 merged commit 1f15cbb into main Oct 11, 2022
@germa89 germa89 deleted the feat/improving-nsel-wrapper branch October 11, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant